Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete_tag method to HfApi #1128

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Oct 21, 2022

Fix #1095.
I created 2 issues in moon-landing while working on it (https://github.com/huggingface/moon-landing/issues/4219 and https://github.com/huggingface/moon-landing/issues/4223 -internal links-).

Simply adds a method to wraps the https://huggingface.co/api/models/gpt2/tag/this_is_a_tag endpoint introduced by https://github.com/huggingface/moon-landing/pull/4005 (internal link).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 21, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 56.94% // Head: 84.46% // Increases project coverage by +27.51% 🎉

Coverage data is based on head (9f069cd) compared to base (53ee96d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1128       +/-   ##
===========================================
+ Coverage   56.94%   84.46%   +27.51%     
===========================================
  Files          41       41               
  Lines        4065     4074        +9     
===========================================
+ Hits         2315     3441     +1126     
+ Misses       1750      633     -1117     
Impacted Files Coverage Δ
src/huggingface_hub/hf_api.py 87.70% <100.00%> (+45.69%) ⬆️
src/huggingface_hub/utils/_errors.py 100.00% <100.00%> (+20.51%) ⬆️
src/huggingface_hub/repository.py 79.37% <0.00%> (+0.86%) ⬆️
src/huggingface_hub/_commit_api.py 92.85% <0.00%> (+3.96%) ⬆️
src/huggingface_hub/utils/_chunk_utils.py 100.00% <0.00%> (+7.14%) ⬆️
src/huggingface_hub/utils/_runtime.py 89.85% <0.00%> (+7.24%) ⬆️
src/huggingface_hub/utils/_hf_folder.py 100.00% <0.00%> (+11.53%) ⬆️
src/huggingface_hub/utils/_deprecation.py 100.00% <0.00%> (+12.28%) ⬆️
src/huggingface_hub/utils/_validators.py 100.00% <0.00%> (+17.24%) ⬆️
src/huggingface_hub/community.py 91.35% <0.00%> (+17.28%) ⬆️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wauplin Wauplin merged commit 720ea11 into main Oct 25, 2022
@Wauplin Wauplin deleted the 1095-add-endpoint-to-delete-tag branch October 25, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a delete_tag method
4 participants