Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image to text (for image captioning) #114

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Add image to text (for image captioning) #114

merged 1 commit into from
Jun 17, 2021

Conversation

osanseviero
Copy link
Member

No description provided.

@osanseviero osanseviero requested a review from Narsil June 17, 2021 07:06
@Narsil
Copy link
Contributor

Narsil commented Jun 17, 2021

Shouldn't we add a template within common ? (Could be a different PR maybe you're on it)

@osanseviero
Copy link
Member Author

Yeah, I will add it to common but I would also like to add appropriate tests with it first :)

@osanseviero osanseviero merged commit 537cc9e into main Jun 17, 2021
@osanseviero osanseviero deleted the captioning branch June 17, 2021 08:12
osanseviero added a commit that referenced this pull request Jun 17, 2021
@osanseviero
Copy link
Member Author

Sorry, I thought you had LGTMed this PR!

I'll send another PR for the common part later on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants