-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make repocard content a property #1147
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for fixing this @nateraw !
I left a comment for a attribute that I think could be removed, otherwise PR's good for me :)
EDIT: CI is broken so don't worry about the 2 failing tests. They are unrelated to this PR anyway. I'll make the CI skip them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🔥
Codecov ReportBase: 84.61% // Head: 84.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 84.61% 84.64% +0.02%
==========================================
Files 41 41
Lines 4096 4102 +6
==========================================
+ Hits 3466 3472 +6
Misses 630 630
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
btw @Wauplin I noticed another unrelated issue with test suite while working on this PR...will open issue + PR fixing it. |
Resolves #1144 by turning
RepoCard.content
into a property with an accompanying setter fn. The setter handles setting.data
and.text
attributes accordingly.This way, when you update the card text or data, the card's content will be updated as well. As an added bonus, if you update
card.content
, it will update the card data and text as well.