Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tag twice doesn't work #1149

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Create tag twice doesn't work #1149

merged 1 commit into from
Nov 3, 2022

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Nov 3, 2022

Due to an update in moon-landing, creating a tag twice on the same repo doesn't work anymore (for good reason).
This PR updates the according test in hfh. Create tag is now officially released yet so no big deal here.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 3, 2022

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 57.12% // Head: 84.61% // Increases project coverage by +27.49% 🎉

Coverage data is based on head (94c226c) compared to base (63bedf9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1149       +/-   ##
===========================================
+ Coverage   57.12%   84.61%   +27.49%     
===========================================
  Files          41       41               
  Lines        4096     4096               
===========================================
+ Hits         2340     3466     +1126     
+ Misses       1756      630     -1126     
Impacted Files Coverage Δ
src/huggingface_hub/repository.py 79.44% <0.00%> (+0.86%) ⬆️
src/huggingface_hub/_commit_api.py 92.85% <0.00%> (+3.96%) ⬆️
src/huggingface_hub/utils/_chunk_utils.py 100.00% <0.00%> (+7.14%) ⬆️
src/huggingface_hub/utils/_runtime.py 89.85% <0.00%> (+7.24%) ⬆️
src/huggingface_hub/utils/_hf_folder.py 100.00% <0.00%> (+11.53%) ⬆️
src/huggingface_hub/utils/_deprecation.py 100.00% <0.00%> (+12.28%) ⬆️
src/huggingface_hub/utils/_validators.py 100.00% <0.00%> (+13.63%) ⬆️
src/huggingface_hub/community.py 91.35% <0.00%> (+17.28%) ⬆️
src/huggingface_hub/utils/_headers.py 100.00% <0.00%> (+17.30%) ⬆️
src/huggingface_hub/utils/_errors.py 100.00% <0.00%> (+20.51%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wauplin Wauplin merged commit a02f2b9 into main Nov 3, 2022
@Wauplin Wauplin deleted the fix-tag-test-in-ci branch November 3, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants