Delete folder with commit endpoint #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Wauplin
changed the title
Codecov ReportBase: 84.57% // Head: 84.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 84.57% 84.62% +0.05%
==========================================
Files 42 42
Lines 4182 4196 +14
==========================================
+ Hits 3537 3551 +14
Misses 645 645
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
coyotte508
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1151 following server-side implementation (https://github.com/huggingface/moon-landing/pull/3826 (internal link)).
CommitOperationDeletehas now a different behavior depending on if the path is a file or a folder. By default, it will try to guess it automatically by looking at a trainling "/" on the path. Otherwise, it is possible to explicitly setis_folder=True. In case of a "file not found error" (most likely due to a folder passed as a file), a custom message is added to theEntryNotFoundError.Also implements a high-level
delete_folder, same as existingdelete_file.Added tests and updated the documentation.