-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename languages to langage + remove duplicate code in tests #1169
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Codecov ReportBase: 57.45% // Head: 84.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
===========================================
+ Coverage 57.45% 84.77% +27.31%
===========================================
Files 42 42
Lines 4196 4196
===========================================
+ Hits 2411 3557 +1146
+ Misses 1785 639 -1146
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Yes we aligned datasets metadata to models' a few months ago. cc @huggingface/datasets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Fix CI (currently broken). Also fix #1130.
And also updated tests/documentation + tried to remove some duplicate code in tests.
For context, it seems that most datasets have now a
language
tag instead oflanguages
:(cc @zaidalyafeai in the end I worked on this issue as our CI was broken because of it)