1162 Reorder operations correctly in commit endpoint #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
LysandreJik
approved these changes
Nov 9, 2022
| @@ -46,3 +50,49 @@ def test_explicit_folder(self): | |||
| def test_is_folder_wrong_value(self): | |||
| with self.assertRaises(ValueError): | |||
| CommitOperationDelete(path_in_repo="path/to/folder", is_folder="any value") | |||
|
|
|||
|
|
|||
| class TestWarnOnOverwritingOperations(unittest.TestCase): | |||
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Thanks for the reviews @coyotte508 @LysandreJik ! I'm merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1162.
With this PR:
create_commit(...). It was not the case before which causes trouble if someone wants to delete then create a file.CommitOperationAddis validated at initialization (no need for.validate()or._upload_info()calls anymore)Warning: I made some breaking changes in
validate_preupload_info,fetch_upload_modesandprepare_commit_payload. I did not care too much as those 3 methods are defined in a private module and used exclusively for the increate_commit. I checked for safety and it's not used anywhere indiffusers,transformers,skopsanddatasets.Potential issue: if someone adds twice the same file, once a LFS content, once a regular content then the final upload mode will be the one from the second operation. Might cause issue with request payload or gitaly. Anyway, this is a weird case so let's not care of the user has an error. A warning message is triggered before upload so the user should notice the problem. (note: this issue was already existing before this PR)
(cc @severo who raised the issue)