Load errors with flair should now be generating proper API errors. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
commented
Jun 18, 2021
| @@ -37,7 +37,7 @@ | |||
| } | |||
|
|
|||
|
|
|||
| @functools.cache | |||
| @functools.lru_cache() | |||
There was a problem hiding this comment.
tiangolo only supports 3.8, and that's equivalent.
Narsil
commented
Jun 18, 2021
osanseviero
approved these changes
Jun 18, 2021
| @@ -1,5 +1,6 @@ | |||
| import logging | |||
| import os | |||
| import functools | |||
There was a problem hiding this comment.
Please fix style, this is not sorted properly
(I see that the automatic check is not checking this directory. I'll send a PR to fix)
| model_id = os.environ["MODEL_ID"] | ||
|
|
||
| app.pipeline = get_pipeline(task, model_id) | ||
| app.get_pipeline = get_pipeline |
There was a problem hiding this comment.
Does this need this below? (just as in #123)
try:
get_pipeline()
except Exception:
# We can fail so we can show exception later.
pass
There was a problem hiding this comment.
It will help usage a bit, not a strict requirement.
With this, starlette will load the model form the start, without it it will load it when first request hits.
(It's only memory load, it will already be on disk because of prestart.sh)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.