Simplify manage to autodetect task+framework if possible. #122
Conversation
|
Could you also quickly change the inference api Actions checks to run in pull_request, not only PR? They don't seem to trigger with latest unless I do manually. Also, |
api-inference-community/manage.py
Outdated
| info = HfApi().model_info(model_id) | ||
| task = info.pipeline_tag | ||
| framework = None | ||
| frameworks = { |
There was a problem hiding this comment.
Nit: please sort frameworks alphabetically :)
There was a problem hiding this comment.
Ahaah is that really that important ? :D
api-inference-community/manage.py
Outdated
| framework = tag | ||
| else: | ||
| raise Exception( | ||
| "This model seems to implement 2 frameworks, we cannot infer" |
There was a problem hiding this comment.
Just a comment: I wonder if this can become an issue later on with models such as sentence-transformers that work fine in both transformers and sentence-transformers.
modelInfo currently does not return the library, but I think it should. It's already there, we just need to add it to the returned modelInfo. I can send a PR for that next week.
There was a problem hiding this comment.
@julien-c is implementing library_name or something similar, so we should be able to switch to that and avoid this edge case.
There was a problem hiding this comment.
This is already done now :)
There was a problem hiding this comment.
You can do info.library_name
No description provided.