Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sentence transformers source to original repo #128

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

osanseviero
Copy link
Member

This might potentially break some of the existing models with the previous v2 (I think they were all mine though), but this will make sure @nreimers can try out Inference API with latest changes.

@Narsil
Copy link
Contributor

Narsil commented Jun 21, 2021

Do you want a full check of the models, or should we just use this from now on ?

@osanseviero
Copy link
Member Author

I checked all models with sentence-transformers tag.

All repo except mine (and two additional repos that have the) follow the v1 structure and there is backwards compatibility, so it should be fine.

@Sahajtomar, I saw you uploaded https://huggingface.co/Sahajtomar/sts-GBERT-de and https://huggingface.co/Sahajtomar/french_semantic. sentence-transformers experimental v2 branch was recently updated to follow a new modules.json format which has more information. This is still prone to change in the incoming days, but I wanted to give a heads up that the Inference API might not work properly.

@Narsil, since @nreimers is testing everything end-to-end, I think we should do the change now to the wip v2 branch.

@Narsil Narsil merged commit c28173f into main Jun 21, 2021
@Narsil Narsil deleted the st-newest-branch branch June 21, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants