Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell user how to paste token on Windows #1289

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Conversation

fristhon
Copy link
Contributor

getpass() can't handle Ctrl+V on Windows which causes "invalid token error" in VSCode and CMD
https://bugs.python.org/issue37426

This causes confusion for the user, actually happened to me several times! so I decided to send this PR for a better UX.

src/huggingface_hub/_login.py Outdated Show resolved Hide resolved
src/huggingface_hub/_login.py Outdated Show resolved Hide resolved
@Wauplin
Copy link
Contributor

Wauplin commented Jan 16, 2023

Hi @fristhon , thanks for your input and for taking the time to make a PR for it. I approved it and will soon merge it :)

(note: I've updated the PR to use os.name == "nt" instead of sys.platform.startswith("win"). It's not better or worse, just more consistent with the existing codebase)

@Wauplin Wauplin merged commit 751472c into huggingface:main Jan 16, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 16, 2023

The documentation is not available anymore as the PR was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants