FIX create_repo with exists_ok but no permission
#1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
==========================================
- Coverage 84.50% 84.50% -0.01%
==========================================
Files 48 48
Lines 4814 4820 +6
==========================================
+ Hits 4068 4073 +5
- Misses 746 747 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
osanseviero
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Conceptual LGTM, but let's wait for @LysandreJik's review :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corner case but used in a lot of integrations. Problem is when doing
create_repo(..., exists_ok). If repo already exists, it's not supposed to raise an exception. However, if the repo exists but the user do not have permission on this namespace, a HTTP 403 is thrown. Since we catch only HTTP 409 conflict, the error is not caught.With this PR, if we get an HTTP 403, we check if the repo exists or not before raising an exception. This is useful for third-party integrations having a "push_to_hub"-like method and
create_pr=True. We do not want to throw an error on create repo since write permission will not be needed to create a PR.See related slack thread (internal link) cc @thomasw21 @coyotte508