Limit to pydantic<2.x on python3.8
#1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Nov 15, 2023
|
Thanks for the quick review! Failing tests are unrelated. I'll merge and make the hot fix release. |
|
Release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we allowed pydantic>=2.x in
v0.19.0release, we got some issues in the CI. The problem comes from the fact that on Python3.8, Pydantic>=2.x and tensorflow don't seem to be compatible. Tensorflow depends ontyping_extension<=4.5.0while pydantic 2.x requirestyping_extensions>=4.6. This causes aImportError: cannot import name 'TypeAliasType' from 'typing_extensions'.Examples of failed CIs:
My plan is to make a new patch release
0.19.3if that works since it's a bit of a regression right now (compared to huggingface_hub 0.18).EDIT: adding related slack convo (internal)
EDIT 2: I made some cleaning in the keras integration and especially the tests (see 079cc54). I kept it iso-feature so that I can still cherry-pick it for a release. We might want to do a more in-depth review of the keras integration at some point but that's not the goal of this PR.