multipart: don't wait for first chunk to be uploaded to start all workers #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierrci
changed the title
Pierrci
changed the title
|
I thought we had done it in |
|
But yeah in any case I approve (my memory on this is blurry to be honest) |
|
You're consistent but nah, it's not in transformers 😄 |
julien-c
added a commit
that referenced
this pull request
May 21, 2021
* Initial examples to ASR & TTS * moved files to cdn-media.hf.co Co-authored-by: Bayartsogt Yadamsuren <bayartsogt.yadamsuren@icloud.com> Co-authored-by: Julien Chaumond <chaumond@gmail.com> commit imported from https://github.com/huggingface/widgets/commit/39b97470ed2b31cf97624b9e14f3c0d4f4f44cf1 * Initial examples to ASR & TTS * moved files to cdn-media.hf.co Co-authored-by: Bayartsogt Yadamsuren <bayartsogt.yadamsuren@icloud.com> Co-authored-by: Julien Chaumond <chaumond@gmail.com>
julien-c
added a commit
that referenced
this pull request
May 21, 2021
* Initial examples to ASR & TTS * moved files to cdn-media.hf.co Co-authored-by: Bayartsogt Yadamsuren <bayartsogt.yadamsuren@icloud.com> Co-authored-by: Julien Chaumond <chaumond@gmail.com> commit imported from https://github.com/huggingface/widgets/commit/39b97470ed2b31cf97624b9e14f3c0d4f4f44cf1 * Initial examples to ASR & TTS * moved files to cdn-media.hf.co Co-authored-by: Bayartsogt Yadamsuren <bayartsogt.yadamsuren@icloud.com> Co-authored-by: Julien Chaumond <chaumond@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got reminded about that by huggingface/autotrain-advanced#18 (comment)