Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐ŸŒ [i18n-KO] Translated guides/upload.md to Korean #2139

Merged
merged 8 commits into from
Apr 19, 2024

Conversation

junejae
Copy link
Contributor

@junejae junejae commented Mar 21, 2024

What does this PR do?

Translated the guides/upload.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (๋ฒˆ์—ญ ๋ˆ„๋ฝ/์ค‘๋ณต ๊ฒ€์‚ฌ)
  • Grammar Check (๋งž์ถค๋ฒ• ๊ฒ€์‚ฌ)
  • Review or Add new terms to glossary (์šฉ์–ด ํ™•์ธ ๋ฐ ์ถ”๊ฐ€)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview๋กœ ์ •์ƒ์ž‘๋™ ํ™•์ธ)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor Author

@junejae junejae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor ์ถ”๊ฐ€

rendered properly in your Markdown viewer.
-->

# ํ—ˆ๋ธŒ์— ํŒŒ์ผ ์—…๋กœ๋“œํ•˜๊ธฐ
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# ํ—ˆ๋ธŒ์— ํŒŒ์ผ ์—…๋กœ๋“œํ•˜๊ธฐ
# ํ—ˆ๋ธŒ์— ํŒŒ์ผ ์—…๋กœ๋“œํ•˜๊ธฐ[[upload-files-to-the-hub]]

Anchor ์ถ”๊ฐ€

docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved

</Tip>

## (๋ ˆ๊ฑฐ์‹œ) Git LFS๋กœ ํŒŒ์ผ ์—…๋กœ๋“œํ•˜๊ธฐ
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## (๋ ˆ๊ฑฐ์‹œ) Git LFS๋กœ ํŒŒ์ผ ์—…๋กœ๋“œํ•˜๊ธฐ
## (๋ ˆ๊ฑฐ์‹œ) Git LFS๋กœ ํŒŒ์ผ ์—…๋กœ๋“œํ•˜๊ธฐ[[legacy-upload-files-with-git-lfs]]

๋งค์šฐ ํฐ ํŒŒ์ผ์ด ์žˆ๋Š” ๊ฐ ๋ฆฌํฌ์ง€ํ† ๋ฆฌ์— ๋Œ€ํ•ด ์ด ์˜ต์…˜์„ ์„ค์น˜ํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.
์„ค์น˜๊ฐ€ ์™„๋ฃŒ๋˜๋ฉด 5GB๋ณด๋‹ค ํฐ ํŒŒ์ผ์„ ํ‘ธ์‹œํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

### ์ปค๋ฐ‹ ์ปจํ…์ŠคํŠธ ๊ด€๋ฆฌ์ž
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### ์ปค๋ฐ‹ ์ปจํ…์ŠคํŠธ ๊ด€๋ฆฌ์ž
### ์ปค๋ฐ‹ ์ปจํ…์ŠคํŠธ ๊ด€๋ฆฌ์ž[[commit-context-manager]]

>>> last_command.failed
```

### push_to_hub
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### push_to_hub
### push_to_hub[[pushtohub]]

Copy link
Contributor

@SeungAhSon SeungAhSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•ˆ๋…•ํ•˜์„ธ์š”! ์ข‹์€ ๋ฒˆ์—ญ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค.
ํ—ˆ๋ธŒ -> Hub๋กœ ์šฉ์–ด๋ฅผ ํ†ต์ผํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„ ์ฝ”๋ฉ˜ํŠธ๋ฅผ ๋‚จ๊ฒผ์Šต๋‹ˆ๋‹ค.
์•ž์œผ๋กœ ์ž˜ ๋ถ€ํƒ๋“œ๋ ค์š” :)

docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@junejae junejae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์‹ ๊ทœ ์ •์ฑ…์— ๋งž๊ฒŒ ์ฃผ์„ ํ•œ๊ธ€ํ™” ์ง„ํ–‰.

docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
ํ‘ธ์‹œ ์ƒํƒœ๋ฅผ ํ™•์ธํ•˜๋Š” ๋ฐ ์œ ์šฉํ•œ ๋ช‡ ๊ฐ€์ง€ ์ถ”๊ฐ€ ๋ช…๋ น์€ ๋‹ค์Œ๊ณผ ๊ฐ™์Šต๋‹ˆ๋‹ค:

```python
# Inspect an error.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Inspect an error.
# ์˜ค๋ฅ˜๋ฅผ ๊ฒ€์‚ฌํ•ฉ๋‹ˆ๋‹ค.

# Inspect an error.
>>> last_command.stderr

# Check whether a push is completed or ongoing.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Check whether a push is completed or ongoing.
# ํ‘ธ์‹œ ์ง„ํ–‰์—ฌ๋ถ€๋ฅผ ํ™•์ธํ•ฉ๋‹ˆ๋‹ค.

# Check whether a push is completed or ongoing.
>>> last_command.is_done

# Check whether a push command has errored.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Check whether a push command has errored.
# ํ‘ธ์‹œ ๋ช…๋ น์˜ ์—๋Ÿฌ์—ฌ๋ถ€๋ฅผ ํŒŒ์•…ํ•ฉ๋‹ˆ๋‹ค.

junejae and others added 2 commits April 2, 2024 23:48
@junejae junejae marked this pull request as ready for review April 2, 2024 14:55
Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ผ๋ถ€ ๋ฒˆ์—ญ์ด ์•ˆ๋œ ์ฃผ์„์ด ์žˆ์Šต๋‹ˆ๋‹ค! ํ™•์ธ ๋ถ€ํƒ๋“œ๋ ค์š” ๐Ÿค—

docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
docs/source/ko/guides/upload.md Outdated Show resolved Hide resolved
@junejae
Copy link
Contributor Author

junejae commented Apr 18, 2024

์ผ๋ถ€ ๋ฒˆ์—ญ์ด ์•ˆ๋œ ์ฃผ์„์ด ์žˆ์Šต๋‹ˆ๋‹ค! ํ™•์ธ ๋ถ€ํƒ๋“œ๋ ค์š” ๐Ÿค—

@jungnerd ๋น ์ง„ ๋ถ€๋ถ„ ์ž‘์—… ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค!

@jungnerd
Copy link
Contributor

jungnerd commented Apr 18, 2024

@Wauplin LGTM. This PR is good to go!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks @junejae and reviewers! ๐ŸŽ‰

@Wauplin Wauplin merged commit 19babe2 into huggingface:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants