Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translating guides/hf_file_system.md to Korean #2146

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

heuristicwave
Copy link
Contributor

@heuristicwave heuristicwave commented Mar 22, 2024

What does this PR do?

Translated the guides/hf_file_system.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd

@heuristicwave heuristicwave changed the title [i18n-KO] Translating guides/hf_file_system.md to Korean 🌐 [i18n-KO] Translating guides/hf_file_system.md to Korean Mar 22, 2024
Copy link
Contributor

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

허브 -> Hub 번역만 수정하였습니다!

docs/source/ko/guides/hf_file_system.md Outdated Show resolved Hide resolved
Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>
Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com>
Copy link
Contributor Author

@heuristicwave heuristicwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석도 번역하기로 결정하여, 바꿔보았습니다

Copy link
Contributor Author

@heuristicwave heuristicwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: translate comments

@heuristicwave heuristicwave marked this pull request as ready for review April 24, 2024 08:43
@jungnerd
Copy link
Contributor

좋은 번역 감사합니다👍
_toctree.yml 에서 해당 문서의 경로 설정과 타이틀 번역이 되지 않은 것 같아요. 확인 부탁드립니다!

@heuristicwave
Copy link
Contributor Author

좋은 번역 감사합니다👍 _toctree.yml 에서 해당 문서의 경로 설정과 타이틀 번역이 되지 않은 것 같아요. 확인 부탁드립니다!

그동안 다른분들 toctree가 머지되다 보니, conflict 해소 과정에서 toctree가 누락되었네요;; 감사합니다

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@jungnerd
Copy link
Contributor

@Wauplin LGTM! I think this PR is ready to merge! 👍

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone!

@Wauplin Wauplin merged commit f54265e into huggingface:main Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants