Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User API endpoints #2147

Merged
merged 8 commits into from
Mar 29, 2024
Merged

Conversation

bilgehanertan
Copy link
Contributor

@bilgehanertan bilgehanertan commented Mar 22, 2024

User API endpoints are implemented.

/likes endpoint was already implemented on hf_api.py:list_liked_repos:2078.

Resolves #2077

@bilgehanertan bilgehanertan mentioned this pull request Mar 22, 2024
5 tasks
@bilgehanertan bilgehanertan changed the title User API endpoints - overview User API endpoints Mar 22, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bilgehanertan thanks a lot for your first contribution! This is really nicely implemented and documented 🔥

I just reviewed your PR. There are quite some comments but most of them are really minimal (just a matter of how to parse the data). Once those changes are done, I think we should be good to merge :)

src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
tests/test_hf_api.py Outdated Show resolved Hide resolved
@bilgehanertan
Copy link
Contributor Author

Hey @bilgehanertan thanks a lot for your first contribution! This is really nicely implemented and documented 🔥

I just reviewed your PR. There are quite some comments but most of them are really minimal (just a matter of how to parse the data). Once those changes are done, I think we should be good to merge :)

Thank you! I will be changing them today.

@bilgehanertan
Copy link
Contributor Author

Hey @bilgehanertan thanks a lot for your first contribution! This is really nicely implemented and documented 🔥

I just reviewed your PR. There are quite some comments but most of them are really minimal (just a matter of how to parse the data). Once those changes are done, I think we should be good to merge :)

I fixed them all 👍

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🔥 Really great job, thanks @bilgehanertan! I just realized I made a mistake in a comment yesterday. Would it be possible to add back is_pro as attribute? Apart from that, it's ready to be merged :) Thanks in advance!

src/huggingface_hub/hf_api.py Show resolved Hide resolved
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks again @bilgehanertan! I'll merge as soon as the CI is green :)

@Wauplin Wauplin merged commit 9ced134 into huggingface:main Mar 29, 2024
13 of 14 checks passed
@Wauplin
Copy link
Contributor

Wauplin commented Mar 29, 2024

Merged it as failing test was unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support User API endpoints
3 participants