Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated reference/login.md to Korean #2151

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

SeungAhSon
Copy link
Contributor

@SeungAhSon SeungAhSon commented Mar 24, 2024

What does this PR do?

Translated the reference/login.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@SeungAhSon SeungAhSon changed the title 🌐 [i18n-KO] Translated reference/login.md to Korean 🌐 [i18n-KO] Translated reference/login.md to Korean Mar 24, 2024
@SeungAhSon SeungAhSon marked this pull request as ready for review March 25, 2024 07:03
Copy link
Contributor Author

@SeungAhSon SeungAhSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor 추가했습니다

docs/source/ko/package_reference/login.md Outdated Show resolved Hide resolved
docs/source/ko/package_reference/login.md Outdated Show resolved Hide resolved
docs/source/ko/package_reference/login.md Outdated Show resolved Hide resolved
docs/source/ko/package_reference/login.md Outdated Show resolved Hide resolved
@SeungAhSon SeungAhSon marked this pull request as draft March 25, 2024 07:44
Copy link
Contributor

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

허브 -> Hub 국문 번역과 관련한 사항을 수정하였습니다!


# 로그인 및 로그아웃

`huggingface_hub` 라이브러리를 사용하면 사용자가 허브에 기계를 프로그래밍 방식으로 로그인하고 로그아웃할 수 있습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`huggingface_hub` 라이브러리를 사용하면 사용자가 허브에 기계를 프로그래밍 방식으로 로그인하고 로그아웃할 수 있습니다.
`huggingface_hub` 라이브러리를 사용하면 사용자가 Hub에 기계를 프로그래밍 방식으로 로그인하고 로그아웃할 수 있습니다.

허브 -> Hub 국문 번역을 하지 않는 것으로 수정하였습니다.

SeungAhSon and others added 2 commits March 29, 2024 03:45
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: 김준재 <55151385+junejae@users.noreply.github.com>
@SeungAhSon SeungAhSon marked this pull request as ready for review March 28, 2024 18:47
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@jungnerd
Copy link
Contributor

@Wauplin LGTM 👍 I think this PR is good to go!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Wauplin Wauplin merged commit 069efbe into huggingface:main Apr 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants