Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated package_reference/hf_api.md to Korean #2165

Merged
merged 11 commits into from
Apr 25, 2024

Conversation

fabxoe
Copy link
Contributor

@fabxoe fabxoe commented Mar 28, 2024

What does this PR do?

Translated the package_reference/hf_api.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

@ArthurZucker
Copy link

cc @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, the structure and format looks good to me!

Please remember to ping Team PseudoLab for a review of the content! 🤗
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae

```python
from huggingface_hub import HfApi, list_models

# Use root method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be a better user experience for Korean readers if the code comments here are also translated. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stevhliu 👋
I agree with your idea.
When I looked at the documentation in other languages, the code comments were not translated, so we left them untranslated, but I think it would be more helpful for Koreans to read the documentation if the code comments are translated.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

docs/source/ko/_toctree.yml Outdated Show resolved Hide resolved
@fabxoe fabxoe marked this pull request as ready for review April 11, 2024 12:44
Copy link
Contributor

@seoyoung-3060 seoyoung-3060 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다
허브->Hub만 수정했습니다!
메서드는 매소드, 메소드 등 아직 방향이 확실히 정해지지 않은 것 같아서 일단 수정하지 않았습니다

docs/source/ko/package_reference/hf_api.md Outdated Show resolved Hide resolved
Co-authored-by: Seoyoung Kim <79852630+seoyoung-3060@users.noreply.github.com>
@jungnerd
Copy link
Contributor

@fabxoe review 확인 부탁드립니다!

Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr>
@jungnerd
Copy link
Contributor

@Wauplin LGTM! This PR is ready to merge!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging it now :)

@Wauplin Wauplin merged commit fa8ed4d into huggingface:main Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants