-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 [i18n-KO] Translated package_reference/hf_api.md
to Korean
#2165
🌐 [i18n-KO] Translated package_reference/hf_api.md
to Korean
#2165
Conversation
cc @stevhliu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, the structure and format looks good to me!
Please remember to ping Team PseudoLab for a review of the content! 🤗
@jungnerd, @heuristicwave, @harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae
```python | ||
from huggingface_hub import HfApi, list_models | ||
|
||
# Use root method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be a better user experience for Korean readers if the code comments here are also translated. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stevhliu 👋
I agree with your idea.
When I looked at the documentation in other languages, the code comments were not translated, so we left them untranslated, but I think it would be more helpful for Koreans to read the documentation if the code comments are translated.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 번역 감사합니다
허브->Hub만 수정했습니다!
메서드는 매소드, 메소드 등 아직 방향이 확실히 정해지지 않은 것 같아서 일단 수정하지 않았습니다
Co-authored-by: Seoyoung Kim <79852630+seoyoung-3060@users.noreply.github.com>
@fabxoe review 확인 부탁드립니다! |
Co-authored-by: Chulhwa (Evan) Han <cjfghk5697@ajou.ac.kr>
@Wauplin LGTM! This PR is ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Merging it now :)
What does this PR do?
Translated the
package_reference/hf_api.md
file of the documentation to Korean.Thank you in advance for your review.
Part of #1626
Before reviewing
[[lowercased-header]]
)Who can review? (Initial)
Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)
@jungnerd, @heuristicwave May you please review this PR?