Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL when uploading to proxy #2167

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Mar 28, 2024

Follow-up PR after #2155 to definitively fix #2152. Thanks @livegoplayer for reporting the remaining issue in #2152 (comment). I made a mistake when trying the fix and my machine was still able to reach hf.co. This PR should settle the problem for good.

@livegoplayer would you mind trying again on your side? You can test it by installing huggingface_hub from this branch:

pip install git+https://github.com/huggingface/huggingface_hub@fix-url-for-good-when-using-procy

You testing scripts from #2152 (comment) looks good so normally upload should correctly work. Please let me know how it goes!

cc @padeoe vor visibility

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@livegoplayer
Copy link

我又测试了一遍
image
image

image

@livegoplayer
Copy link

@livegoplayer
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin
Copy link
Contributor Author

Wauplin commented Mar 28, 2024

Hi @livegoplayer I just pushed a (last?) fix: 64abc0e. This was an oversight from my side. Just for the record:

I previously forgot to distinguish the "single part" and "multi part" LFS workflows, that's why you got an error while I didn't. I only tried to upload a 1kb LFS file which has 1 step less than your 150MB file (since the 150Mb is split in chunks of 16MB). Anyway, I hope all issues are now fix. @livegoplayer could you retry and confirm? Thank you in advance 🙏

@livegoplayer
Copy link

你好@livegoplayer我刚刚推送了一个(最后一个?)修复:64abc0e。这是我的疏忽。仅供记录:

我之前忘记区分“单部分”和“多部分”LFS 工作流程,这就是为什么你收到错误而我没有。我只尝试上传一个 1kb LFS 文件,该文件比您的 150MB 文件少 1 步(因为 150Mb 被分成 16MB 的块)。无论如何,我希望所有问题现在都得到解决。@livegoplayer您可以重试并确认吗?提前谢谢🙏

我测试成功了,我上传了一个很多g的文件,并且成功了

@Wauplin
Copy link
Contributor Author

Wauplin commented Mar 28, 2024

Yay! 🎉
Thanks for confirming! We should be good to go then :)

@Wauplin Wauplin merged commit b1c7f63 into main Mar 29, 2024
16 checks passed
@Wauplin Wauplin deleted the fix-url-for-good-when-using-procy branch March 29, 2024 11:48
Wauplin added a commit that referenced this pull request Mar 29, 2024
* Fix URL when uploading to proxy

* fix multi-part LFS upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use HF_ENDPOINT will still be connected to huggingface.co
3 participants