🌐 [i18n-KO] Translated package_reference/inference_types.md to Korean
#2171
Conversation
fabxoe
changed the title
reference/inference_types.md to Koreanpackage_reference/inference_types.md to Korean
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: boyunJang <46440074+boyunJang@users.noreply.github.com> Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com> Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com>
|
|
||
|
|
||
|
|
||
| ## audio_classification[[huggingface_hub.AudioClassificationInput]] |
There was a problem hiding this comment.
Hi, @Wauplin !
Should we translate the task name (ex. audio_classification) in the heading or leave it as is?
There was a problem hiding this comment.
Good question. I think you can either keep them in English since these are "constrained" tags. Or have both the Korean + English versions in the same title like audio-classification (오디오 분류) [[huggingface_hub.AudioClassificationInput]] (disclaimer: translated with google translate).
There was a problem hiding this comment.
@fabxoe님은 둘 중에 어떤 방법으로 하는 게 좋다고 생각하시나요?
There was a problem hiding this comment.
@jungnerd 님,
결국에는 제 생각에는 그대로 두는것도 나쁘지 않아보입니다.
해당 부분의 원래 의도는 네이밍을 공유하는 비슷한 기능의 클래스들을 나열해 두고 네이밍의 공통 부분을 표현하기 위해서 대략 snake style로 작성된 것으로 보입니다.
class huggingface_hub.DocumentQuestionAnsweringInput
class huggingface_hub.DocumentQuestionAnsweringInputData
class huggingface_hub.DocumentQuestionAnsweringOutputElement
이 클래스들의 타입명은 'document_question_answering' 로 단순한데 이대로 가독성이 좋습니다.
이것을 한글로 번역할 때 의미를 전달하고자 하는 의도였다면 '문서 질문 답변' 처럼 그대로 단순 번역이 되어 이해에 추가적인 도움이 되지는 않을 것 같습니다.
시각적인 의도라면 영어와 한글을 병기시 우측의 toctree의 메뉴의 너비도 커지지 않을까 합니다.
There was a problem hiding this comment.
@Wauplin After your suggestion, we've been thinking about it and we think it's better to leave the task name untranslated. Thank you for the idea!
There was a problem hiding this comment.
Works for me as well. Thanks for iterating on it!
|
@Wauplin LGTM! This PR is ready to merge 🚀 |
What does this PR do?
Translated the
package_reference/inference_types.mdfile of the documentation to Korean.Thank you in advance for your review.
Part of #1626
Before reviewing
[[lowercased-header]])Who can review? (Initial)
Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)
@jungnerd, @heuristicwave May you please review this PR?