Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐ŸŒ [i18n-KO] Translated package_reference/inference_client.md to Korean #2178

Merged

Conversation

cjfghk5697
Copy link
Contributor

@cjfghk5697 cjfghk5697 commented Apr 1, 2024

What does this PR do?

Translated the package_reference/inference_client.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (๋ฒˆ์—ญ ๋ˆ„๋ฝ/์ค‘๋ณต ๊ฒ€์‚ฌ)
  • Grammar Check (๋งž์ถค๋ฒ• ๊ฒ€์‚ฌ)
  • Review or Add new terms to glossary (์šฉ์–ด ํ™•์ธ ๋ฐ ์ถ”๊ฐ€)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview๋กœ ์ •์ƒ์ž‘๋™ ํ™•์ธ)

Who can review? (Initial)

Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?

Copy link
Contributor

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์€ ๋ฒˆ์—ญ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค! ๋ฌธ์žฅ์˜ ๋‚ด์žฌ ์ •๋ณด๋ฅผ ๋ฐ˜์˜ํ•˜์—ฌ ํ•ด์„์„ ํ•˜๋‚˜ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

docs/source/ko/package_reference/inference_client.md Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@fabxoe
Copy link
Contributor

fabxoe commented Apr 10, 2024

LGTM!

Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com>
@cjfghk5697 cjfghk5697 marked this pull request as ready for review April 11, 2024 12:41
@jungnerd
Copy link
Contributor

@Wauplin LGTM! I think this PR is good to go!

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @cjfghk5697 and other reviewers! ๐ŸŽ‰

@Wauplin Wauplin merged commit c4f522c into huggingface:main Apr 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants