Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated package_reference/space_runtime.md to Korean #2213

Merged

Conversation

boyunJang
Copy link
Contributor

@boyunJang boyunJang commented Apr 10, 2024

What does this PR do?

Translated the package_reference/space_runtime.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #1626

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team Hugging Face KREW, may you please review this PR?
@harheem, @cjfghk5697, @seoulsky-field, @nuatmochoi, @boyunJang, @SeungAhSon, @seoyoung-3060, @junejae, @usr-bin-ksh, @fabxoe

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@jungnerd, @heuristicwave May you please review this PR?


# 스페이스 런타임 관리[[managing-your-space-runtime]]

[`HfApi`] 문서 페이지를 확인하여 Hub에서 스페이스를 관리하는 메소드에 대한 참조를 확인하세요.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[`HfApi`] 문서 페이지를 확인하여 Hub에서 스페이스를 관리하는 메소드에 대한 참조를 확인하세요.
Hub의 스페이스를 관리하는 메소드에 대한 자세한 설명은 [`HfApi`]페이지를 확인하세요.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참조와 확인 이라는 의미가 비슷한 문구가 여러번 나오니, 한글문장에서는 어색해서 한번만 사용하도록 변경해보았습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다시 보니 문장이 어색하긴 했네요...! 덕분에 다른 문서도 비슷하게 수정하러 갑니다 감사합니다:)

Copy link
Contributor

@seoulsky-field seoulsky-field left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다! Space가 고유명사로 사용되고 있어서 이를 국문 번역하지 않는 것으로 수정해보았습니다 :)

docs/source/ko/package_reference/space_runtime.md Outdated Show resolved Hide resolved
docs/source/ko/package_reference/space_runtime.md Outdated Show resolved Hide resolved
docs/source/ko/package_reference/space_runtime.md Outdated Show resolved Hide resolved
Co-authored-by: Kyungmin Jeon <83350060+seoulsky-field@users.noreply.github.com>
@boyunJang boyunJang marked this pull request as ready for review April 11, 2024 12:50
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
@jungnerd
Copy link
Contributor

@Wauplin LGTM! Ready to merge 🚀

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🤗

@Wauplin Wauplin merged commit 2ca5b15 into huggingface:main Apr 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants