add warning tip that list_deployed_models only searches over cache #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks @MoritzLaurer!
(I also share concerns about the usability of this method TBH 😕)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a small warning tip based on this internal discussion.
General thought: I'm wondering how useful the
list_deployed_modelsmethod actually is for users if they don't know if the list is up to date and they need to check with InferenceClient.get_model_status anyways. Could we have a cached list that is updated every N minutes or something like that? No idea how complicated that would be to implemented in the backend. @Wauplin @Narsil