Respect default timeouts in hf_file_system
#2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
commented
Apr 26, 2024
| @@ -122,7 +124,7 @@ def _repo_and_revision_exist( | |||
| ) -> Tuple[bool, Optional[Exception]]: | |||
| if (repo_type, repo_id, revision) not in self._repo_and_revision_exists_cache: | |||
| try: | |||
| self._api.repo_info(repo_id, revision=revision, repo_type=repo_type) | |||
| self._api.repo_info(repo_id, revision=revision, repo_type=repo_type, timeout=HF_HUB_ETAG_TIMEOUT) | |||
There was a problem hiding this comment.
This is not per-se a ETAG call (not a HEAD) but it is the proxy we use to confirm repo existence => serves the same purpose.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks for the quick review! |
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For normal downloads (i.e.
hf_hub_downloadandsnapshot_download), we have configurable valuesHF_HUB_ETAG_TIMEOUTandHF_HUB_DOWNLOAD_TIMEOUT. Let's use them in the hf filesystem as well to avoid long-lasting requests (current default is to wait indefinitely, now set to 10s).Related to huggingface/dataset-viewer#2752.