Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mv interfaces -> widgets/lib/interfaces #227

Merged
merged 2 commits into from Jul 28, 2021
Merged

Conversation

mishig25
Copy link
Contributor

As discussed in #202, moving interfaces folder to widgets/lib/interfaces

What's been done:

  1. Move all files from interfaces to widgets/lib/interfaces & delete original interfaces folder
  2. Update workflows for Github actions, updating widgets/lib/interfaces path
  3. Update readmes, updating widgets/lib/interfaces path

@mishig25 mishig25 requested a review from Pierrci July 27, 2021 11:01
Copy link
Member

@Pierrci Pierrci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mishig25!

Can you open a small PR in moon-landing to reflect the changes in paths once you merge this one? (you'll also need to update the huggingface_hub submodule)

I know this will be rendered obsolete soon once we switch to package import but until then... :)

@mishig25 mishig25 merged commit 6b552ef into main Jul 28, 2021
@mishig25 mishig25 deleted the widgets_interfaces_dir branch July 28, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants