Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy_cache_layout parameter in hf_hub_download #2317

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jun 5, 2024

From a suggestion from @julien-c. It's not used since Aug 2022 so time to remove it for real I think? :)

This PR deprecates:

  • filename_to_url
  • url_to_filename
  • cached_download
  • legacy_cache_layout parameter

Deprecation is expected for release 0.26.

I took care of fixing HF libraries that had remaining occurrences. None of them were in highly-used part of the code anyway.

@Wauplin Wauplin requested a review from LysandreJik June 5, 2024 15:47
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin Wauplin requested a review from julien-c June 7, 2024 12:30
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@Wauplin Wauplin merged commit a626cc3 into main Jun 13, 2024
16 checks passed
@Wauplin Wauplin deleted the deprecate-legacy-cache-layout branch June 13, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants