Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics to API #429

Merged
merged 4 commits into from Oct 26, 2021
Merged

Add metrics to API #429

merged 4 commits into from Oct 26, 2021

Conversation

mariosasko
Copy link
Contributor

Adds a list_metrics method to HfApi. We need this method on the Datasets side to be able to remove the Datasets HfApi implementation and use huggingface_hub.HfApi instead.

cc: @lhoestq

@mariosasko mariosasko mentioned this pull request Oct 20, 2021
Merged
julien-c
julien-c reviewed Oct 20, 2021
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of nits but otherwise LGTM

docs/hub/endpoints.md Outdated Show resolved Hide resolved
src/huggingface_hub/hf_api.py Outdated Show resolved Hide resolved
@julien-c
Copy link
Member

pinging @LysandreJik for a quick review but LGTM

LysandreJik
LysandreJik approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @mariosasko

@LysandreJik LysandreJik merged commit e2a83ca into main Oct 26, 2021
@LysandreJik LysandreJik deleted the add-metrics-to-api branch October 26, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c approved these changes

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariosasko @julien-c @LysandreJik