-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding api-inference-community
to huggingface_hub
.
#48
Conversation
Thanks! Looks good to me but adding @LysandreJik and @n1t0 to the party |
Does the CI take a long time? If it does, maybe we'll want to restrict the Inference-API's CI to changes to that folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, looking forward to having everything centralized.
Not sure how easy to run conditional actions but if it's easy then yes let's do it ! Otherwise the CI is super fast as we only run the package CI, everything else is considered "slow" as it would require model downloads (and I don't want to force users to test against dummy models as it is a bit more complex to do). Before deployment, we run the Conditional full docker tests would be the best so that PR creators can be alerted early if something doesn't fit. |
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Hi @julien-c do you think the changes made are OK? I added a simple docker test only for allennlp (afaik, I would need one for each framework, because we can't have multiple Also I am not 100% sure about this docker because it does not seem to run on this PR, is that normal ? I though GH actions should run on current PR, but maybe I'm wrong. |
not sure why the CI suite doesn't run, maybe it will after we merge this first PR? or maybe add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Narsil!
I'm pretty sure it's normal that the CI doesn't run as long as this isn't on master
, we had the same issue on transformers a while back.
api-inference-community
should be relatively independant fromhuggingface_hub
still.