-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[interfaces] Expose configuration options for external libraries #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This is very useful :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this is clean, only nits.
snippet: (model: ModelData) => string; | ||
} | ||
|
||
//#region snippets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those comments for vscode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes sir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though they might be some sort of cross-editor standard syntax? not sure
/** | ||
* Add your new library here. | ||
*/ | ||
export enum ModelLibrary { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the ModelLibrary
be built from the MODEL_LIBRARIES_UI_ELEMENTS
so that users contributors have less to fill? It seems to be close to 1-to-1 with the btnLabel
in the MODEL_LIBRARIES_UI_ELEMENTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could remove the btnLabel if indeed we expect it to already be the same string.
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Reviewers: see also upcoming PR in moon-landing [internal]