[interfaces] Expose configuration options for external libraries #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierrci
approved these changes
May 24, 2021
osanseviero
approved these changes
May 25, 2021
LysandreJik
approved these changes
May 25, 2021
| snippet: (model: ModelData) => string; | ||
| } | ||
|
|
||
| //#region snippets |
There was a problem hiding this comment.
Are those comments for vscode?
There was a problem hiding this comment.
though they might be some sort of cross-editor standard syntax? not sure
| /** | ||
| * Add your new library here. | ||
| */ | ||
| export enum ModelLibrary { |
There was a problem hiding this comment.
Could the ModelLibrary be built from the MODEL_LIBRARIES_UI_ELEMENTS so that users contributors have less to fill? It seems to be close to 1-to-1 with the btnLabel in the MODEL_LIBRARIES_UI_ELEMENTS
There was a problem hiding this comment.
I guess we could remove the btnLabel if indeed we expect it to already be the same string.
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: see also upcoming PR in moon-landing [internal]