Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing repo visibility programmatically #61

Merged
merged 7 commits into from
May 31, 2021
Merged

Conversation

osanseviero
Copy link
Member

Previous discussion in #53

@osanseviero osanseviero marked this pull request as draft May 31, 2021 12:14
@julien-c
Copy link
Member

lgtm but will wait for @LysandreJik to get an extra set of eyes

@julien-c
Copy link
Member

Note: when CI fails for transient errors you should be able to relaunch it till it's green :)

@julien-c
Copy link
Member

(not sure that's the case here though)

@osanseviero
Copy link
Member Author

This is not a transient error, it seems to be an issue with the dataset tests. I'm checking everything works properly :)

@osanseviero osanseviero marked this pull request as ready for review May 31, 2021 13:39
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is clean! LGTM

@osanseviero osanseviero merged commit 6dd2757 into main May 31, 2021
@osanseviero osanseviero deleted the private branch May 31, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants