Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inference API wrapper client #65
Inference API wrapper client #65
Changes from all commits
603e868
b530ec3
c9f2cd4
b2d8d28
0f7b1c9
8e516a1
791a77f
6f6abf3
1a5c42d
932a0e1
b8bbacc
2426bee
c162521
3d8616e
6ec6cf6
44aea80
cb301f8
c45595d
c424ae3
51eaff6
44446a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned offline with @osanseviero, I think handling exceptions here is the most pythonic way to handle things - and that without such logic there's little value in having a Python wrapper for the inference API if it's a glorified
cURL
utility.I would argue that the wrapper's ability to return appropriate errors such as
raise ModelNotLoadedError
orraise MissingKeyError
, which inherit from the appropriate canonic errors (ValueError
,OSError
), is very important API-wise.