New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove docs, tasks and inference API from huggingface_hub #833
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! this is going to be way cleaner!!
Aren't they mostly stale? I would advocate to remove |
Alright, so I did a couple of things
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive diff! Thanks for taking care of that, @osanseviero.
The edit of the contributing guide & readme look good to me. Will be super clean like that!
(out of scope) I wonder if the readme shouldn't be beefed up a bit now to provide code samples, examples etc. I think the README is a big source of traffic, so making it as welcoming/easy to get started as possible would be nice.
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
Yes, totally. As mentioned above, "Updates the README. It has lots of improvement headroom, but the proposal is better than what is over there right now I think", so for sure we can significantly improve things, but I would like to merge this for now since this PR is already better than what exists now. WDYT? (alternatively I could also move content from the README under huggingface_hub directory, WDYT?) |
Fine for me to merge like this yes, and let's revisit the README in another PR. Having a separate README in the |
This PR removes content under
docs
,tasks
, andapi-inference-community
since there is no active development in this repo anymore for that. The PR does not removejs
since there are a couple of PRs open for it still.