Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs, tasks and inference API from huggingface_hub #833

Merged
merged 5 commits into from Apr 12, 2022

Conversation

osanseviero
Copy link
Member

This PR removes content under docs, tasks, and api-inference-community since there is no active development in this repo anymore for that. The PR does not remove js since there are a couple of PRs open for it still.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 11, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! this is going to be way cleaner!!

@julien-c
Copy link
Member

The PR does not remove js since there are a couple of PRs open for it still.

Aren't they mostly stale? I would advocate to remove js sooner rather than later

@osanseviero
Copy link
Member Author

Alright, so I did a couple of things

  • Removed js cc @mishig25 since you have a couple of PRs here
  • Removed parts of contributing guide about the removed directories
  • Updates the README. It has lots of improvement headroom, but the proposal is better than what is over there right now I think

@osanseviero
Copy link
Member Author

cc @NimaBoscarino

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive diff! Thanks for taking care of that, @osanseviero.

The edit of the contributing guide & readme look good to me. Will be super clean like that!

(out of scope) I wonder if the readme shouldn't be beefed up a bit now to provide code samples, examples etc. I think the README is a big source of traffic, so making it as welcoming/easy to get started as possible would be nice.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Lysandre Debut <lysandre@huggingface.co>
@osanseviero
Copy link
Member Author

(out of scope) I wonder if the readme shouldn't be beefed up a bit now to provide code samples, examples etc. I think the README is a big source of traffic, so making it as welcoming/easy to get started as possible would be nice.

Yes, totally. As mentioned above, "Updates the README. It has lots of improvement headroom, but the proposal is better than what is over there right now I think", so for sure we can significantly improve things, but I would like to merge this for now since this PR is already better than what exists now. WDYT? (alternatively I could also move content from the README under huggingface_hub directory, WDYT?)

@LysandreJik
Copy link
Member

Fine for me to merge like this yes, and let's revisit the README in another PR. Having a separate README in the src/huggingface_hub directory indeed doesn't make a lot of sense anymore.

@osanseviero osanseviero merged commit 1d66b06 into huggingface:main Apr 12, 2022
@osanseviero osanseviero deleted the remove-docs branch April 12, 2022 21:09
@LysandreJik LysandreJik mentioned this pull request Apr 21, 2022
1 task
@osanseviero osanseviero mentioned this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants