-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling Keras download stats #860
Conversation
The documentation is not available anymore as the PR was closed or merged. |
I'm checking out why |
What is the consequence of this change? |
(Leaving notes to myself)
(called from |
@adrinjalali when we add library name and version to snapshot download it sends a request with the info inside the header that later gives us statistics about Keras downloads. |
Ah I see, so it doesn't really change anything on the client side. Got it. |
There's a problem with dataset tags. I'm fixing it. |
There's a dataset that is empty after the dataset |
Should we be ignoring those datasets then? As in, if there's an issue creating the class, ignore the entry. In general, we should be safe against malformed data that people put on the hub. |
@adrinjalali if @osanseviero approves. Zach said he reached out to owners of dataset to remove them. |
This internal PR from @julien-c will prevent this situation in the future https://github.com/huggingface/moon-landing/pull/2822 |
@osanseviero I re-ran and problems seem to be gone. |
Yes, we chatted with the model authors and fixed in the backend. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks 🔥
This PR adds
library_name
andlibrary_version
tosnapshot_download
in Keras mixin.I think existing
from_pretrained_keras
tests should cover this so I didn't write an additional test.