Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable link in huggingface-cli #866

Merged
merged 1 commit into from May 9, 2022

Conversation

leondz
Copy link
Contributor

@leondz leondz commented May 6, 2022

When invoking huggingface-cli login without active authentication, a helpful feedback message containing a link to the tokens page is given. The link however is followed immediately by a full stop . so that it lands on a 404 when clicked (macOS / "hyper" shell). This PR adds one space to avoid the false 404 and land on the right page.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @leondz!

@LysandreJik LysandreJik merged commit da25c67 into huggingface:main May 9, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 9, 2022

The documentation is not available anymore as the PR was closed or merged.

@leondz leondz deleted the login-uri-fix branch May 9, 2022 13:52
LysandreJik pushed a commit that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants