MNT deprecate imports from snapshot_download #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
It seems |
|
That looks very nice |
LysandreJik
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Looks great, thanks for working on it @adrinjalali! Only left a nit regarding testing.
tests/test_snapshot_download.py
Outdated
|
|
||
| def test_snapshot_download_import(): | ||
| with pytest.warns(FutureWarning, match="has been made private"): | ||
| from huggingface_hub.snapshot_download import snapshot_download # noqa |
There was a problem hiding this comment.
Could we also check that the method is the same as the one imported from from huggingface_hub import snapshot_download?
|
Perfect, thank you @adrinjalali! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #874 we had to rename the
snapshot_download.pyfile which makesfrom huggingface_hub.snapshot_download import blahfail.This PR deprecated such imports and warns the user instead of failing.
Ref: scientific-python/lazy-loader#9
cc @LysandreJik @osanseviero
P.S.: I won't be available to apply suggestions here this week, but I think we should have this in the release. If you think anything needs to be changed in this PR, please apply the suggestions and then merge :)