Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding audio-to-audio task. #93

Merged
merged 3 commits into from
Jun 10, 2021
Merged

Adding audio-to-audio task. #93

merged 3 commits into from
Jun 10, 2021

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Jun 9, 2021

  • Removed audio-source-separation (it's not audio-to-audio and it is a
    bit more general). Also the previous version was flawed as there was no way
    to return multiple channels.
  • Decision to return base64 blobs in JSON. It's not super shiny but it does
    the work and enabled easy ways to add annotations for audio streams
    (like the instrument labels for source separation).
  • Added GZipMiddleware within common, this help base64 encoded json be
    omewhat ok in terms of size.
  • Known caveat. Currently we only send 1 channel to the input of the
    pipeline. At the moment of this commit, no model requires stereo or multi
    channel input, so keeping that change for later.
  • community framework update will follow.
  • Because of dockerized versionning we can safely delete
    audio-source-separation. Old api-inference-community will continue to
    support those and the hub too. But if you want to use > 0.0.7 then you will
    need to migrate.

- Removed `audio-source-separation` (it's not `audio-to-audio` and it is
a bit more general). Also the previous version was flawed as there was
no way to return multiple channels.
- Decision to return base64 blobs in JSON. It's not super shiny but it
does the work and enabled easy ways to add annotations for audio streams
(like the instrument labels for source separation).
- Added GZipMiddleware within common, this help base64 encoded json be
omewhat ok in terms of size.
- Known caveat. Currently we only send 1 channel to the input of the
pipeline. At the moment of this commit, no model requires stereo or
multi channel input, so keeping that change for later.
- community framework update will follow.
- Because of dockerized versionning we can safely delete
`audio-source-separation`. Old `api-inference-community` will continue
to support those and the hub too. But if you want to use > 0.0.7 then
you will need to migrate.
Copy link
Member

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm taking a look at the other PR and will stamp this one :)

@osanseviero osanseviero self-requested a review June 9, 2021 15:47
@osanseviero
Copy link
Member

This is awesome 🚀 Thank you!

@Narsil Narsil merged commit 82ee99b into main Jun 10, 2021
@Narsil Narsil deleted the add_audio_to_audio branch June 10, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants