Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When pipelines fail to load in framework code, for whatever reason #96

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Jun 10, 2021

We need to display some error about what is happening.

Copy link
Member

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

As discussed by chat, for the future let's try to find a solution close to using functools @lru_cache decorator which in theory is thread-safe, but as chatted it can fail in some cases, so I'm ok with going ahead with this implementation.

api-inference-community/tests/test_routes.py Show resolved Hide resolved
@Narsil Narsil force-pushed the pipeline_errors_are_displayed branch from 708425c to 80b8f46 Compare June 10, 2021 13:52
@Narsil Narsil merged commit 51d260d into main Jun 10, 2021
@Narsil Narsil deleted the pipeline_errors_are_displayed branch June 10, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants