Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of a task should be configurable. #172

Closed
PhilipMay opened this issue Apr 24, 2024 · 6 comments
Closed

Version of a task should be configurable. #172

PhilipMay opened this issue Apr 24, 2024 · 6 comments

Comments

@PhilipMay
Copy link
Contributor

PhilipMay commented Apr 24, 2024

The LightevalTask class has a VERSION. This is not configurable and fixed to 0. See:

I think in the results table the version number is also displayed. See:

Task Version Metric Value Stderr
all acc 0.8737 ± 0.0094
acc_norm 0.8737 ± 0.0094
community:german_rag_eval:_average:0 acc 0.8737 ± 0.0094
acc_norm 0.8737 ± 0.0094
community:german_rag_eval:choose_context_by_question:0 0 acc 0.7290 ± 0.0141
acc_norm 0.7290 ± 0.0141
community:german_rag_eval:choose_question_by_context:0 0 acc 0.8490 ± 0.0113
acc_norm 0.8490 ± 0.0113
community:german_rag_eval:context_question_match:0 0 acc 0.9770 ± 0.0047
acc_norm 0.9770 ± 0.0047
community:german_rag_eval:question_answer_match:0 0 acc 0.9400 ± 0.0075
acc_norm 0.9400 ± 0.0075

If I slightly change the task or the prompt (e.g. #171 ) - it would be nice to increase the version number. Should this be changed / added?

@jphme
Copy link
Contributor

jphme commented Apr 27, 2024

Would also appreciate this feature (and obviously someone thought of this already, given the existence of VERSION). 👍

@clefourrier
Copy link
Member

Hi! Yep, we'll need to add the mechanism again - we had removed it to simplify the code, and because we did not want to fix any task version while still being in alpha.

@PhilipMay PhilipMay changed the title Should the version of a task be configurable? The version of a task be configurable. Apr 29, 2024
@PhilipMay PhilipMay changed the title The version of a task be configurable. Version of a task should be configurable. Apr 29, 2024
@PhilipMay
Copy link
Contributor Author

@clefourrier do you want me to suggest a PR or do you want to implement it?

@clefourrier
Copy link
Member

If you have the time to open a PR I'd be grateful!
You'll need to add a default version argument to the TaskConfig, and edit the task_table.jsonl to set "version" to 0 there for all tasks, and edit your own to pass it to 1.

@PhilipMay
Copy link
Contributor Author

If you have the time to open a PR I'd be grateful! You'll need to add a default version argument to the TaskConfig, and edit the task_table.jsonl to set "version" to 0 there for all tasks, and edit your own to pass it to 1.

I started here: #181

@PhilipMay
Copy link
Contributor Author

This is done with PR #181. Closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants