-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version config option. #181
Add version config option. #181
Conversation
You write:
I do not understand why. When version has the default of 0 I do not need to change that file. What do you think? |
@clefourrier can you please review the PR. I added some TODO comments. They need to be checked. @jphme maybe you also could have a quick look? |
Hi @PhilipMay ! |
Ahh I see. I made the change. |
398a057
to
0700f0c
Compare
Should I also set the version to 0 in https://github.com/huggingface/lighteval/blob/main/community_tasks/arabic_evals.py ? |
Yep, let's be exhaustive :) |
I am done with that. |
Nice! Just need to merge main in your branch and I think we'll be good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks, let's merge once the tests pass
see #172