fix llm as judge warnings #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanHB
commented
Apr 30, 2024
clefourrier
reviewed
Apr 30, 2024
|
Now loads openai lazily. the dep is no linger required when using lighteval |
|
You could add a warning/error when loading metrics at the task level, to check there the deps if needed. |
you mean like I did in task.py to check that the token is set ? |
clefourrier
reviewed
May 31, 2024
clefourrier
reviewed
May 31, 2024
|
And for both of these, I mean using the same checks as for all the other optional deps :) (using new functions defined in utils) |
|
@NathanHB I added the import testing I was thinking about - I'll let you review and if it works for you you can merge |
clefourrier
approved these changes
Jul 3, 2024
hynky1999
pushed a commit
to hynky1999/lighteval
that referenced
this pull request
Jul 12, 2024
* commit * fixes * fix style * fixes * make style * Fix import error detection for open ai package (llm as a judge metric) --------- Co-authored-by: Nathan Habib <nathan.habib@huggingface.com> Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.