Apply new Python API features from OpenVINO 2023.0 release #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
echarlaix
approved these changes
Apr 13, 2023
| @@ -447,9 +447,8 @@ def __init__( | |||
|
|
|||
| def _create_inference_request(self): | |||
| if self.request is None: | |||
| logger.info("Compiling the encoder and creating the inference request ...") | |||
There was a problem hiding this comment.
It would be great to rename the _create_inference_request method to _compile for stable diffusion models as well to keep uniformity
|
|
||
| # Check if inputs are c-like, if not - convert them | ||
| input_ids = _contiguous_helper(np.array(input_ids)) |
There was a problem hiding this comment.
It looks much clearer now ! Could this also be integrated for OVModelForCausalLM from modeling_decoder.py as well ? happy to do it it in a following PR if not
There was a problem hiding this comment.
I edited it as much as I could. Hopefully it's better now!:)
I am sorry for the late response here. However, now OV is bumped in setup.py and features can be used from the official release.
jiwaszki
changed the title
added 2 commits
June 1, 2023 05:53
echarlaix
approved these changes
Jun 1, 2023
Co-authored-by: Ella Charlaix <80481427+echarlaix@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests features from main branch of OpenVINO including:
OVDictthat is able to address elements with string valuesCompiledModel.__call__with automatic request creationThis PR can be tested against openvinotoolkit/openvino#16665