Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: self.config -> self.model.config else throws up error during evaluation in INCSeq2SeqTrainer. #335

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix: self.config -> self.model.config else throws up error during evaluation in INCSeq2SeqTrainer. #335

merged 1 commit into from
Jun 5, 2023

Conversation

AbhishekSalian
Copy link
Contributor

What does this PR do?

  • The predictions during evaluation are converted into ids. model.config was missing so the prediction was not converted to a token because of the missing hyperparameter in the model config.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 5, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

echarlaix
echarlaix approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the fix @AbhishekSalian

@echarlaix echarlaix merged commit f10eef0 into huggingface:main Jun 5, 2023
10 checks passed
@echarlaix echarlaix mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarlaix echarlaix echarlaix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AbhishekSalian @HuggingFaceDocBuilderDev @echarlaix