Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TGI Dockerfile #3

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix TGI Dockerfile #3

merged 1 commit into from
Mar 13, 2024

Conversation

shub-kris
Copy link
Contributor

What does this PR do?

This PR fixes the Dockerfile by copying missing cargo.lock file.

We encountered an issue as discussed here.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

tengomucho
tengomucho approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@tengomucho tengomucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tengomucho
Copy link
Collaborator

For info, this is the same fix as https://github.com/huggingface/Google-Cloud-Containers/pull/24, where the lockfile was forgotten, leading to unreliable builds.

@tengomucho tengomucho merged commit 4c75f88 into main Mar 13, 2024
1 check passed
@mfuntowicz mfuntowicz deleted the fix/tgi_dockerfile branch April 29, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengomucho tengomucho tengomucho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shub-kris @tengomucho