Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Pytorch 2.3.0 and transformers v4.40.2 #41

Merged
merged 5 commits into from
May 23, 2024

Conversation

tengomucho
Copy link
Collaborator

@tengomucho tengomucho commented May 16, 2024

What does this PR do?

A rather uninteresting PR, that updates Pytorch and transformers dependency versions, and makes sure that everything still works as before.
This will however allow to integrate some features that have been integrated on PT2.3 and newer transformers vesions.

Before submitting

  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Now EosTokenCriteria in transformers requires inputs to have at least 2
dimensions, but the TGI generator was giving only one. Unsqueezing those
seem to fix the issue.
Setting it to current nightly, because earlier versions do not see the
libtpu and fail.
Also the basic python test that checks if XLA device is removed, since
it was flawed beccause it could fall back to CPU and not detecting
anything, and also because the `make tgi_test` command in the workflow
was re-installing a different torch xla and libtpu versions anyway.
@tengomucho tengomucho force-pushed the alvaro/update-pt23-transformers4.40 branch from 1626217 to 213991d Compare May 20, 2024 08:30
@tengomucho
Copy link
Collaborator Author

I will update to transformers 4.41 later, because there are some incompatibilities due to changes in static KV cache handling.

@tengomucho tengomucho merged commit 97ba961 into main May 23, 2024
1 check passed
@tengomucho tengomucho deleted the alvaro/update-pt23-transformers4.40 branch May 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant