Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): update server and port when serving TGI #53

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

tengomucho
Copy link
Collaborator

@tengomucho tengomucho commented Jun 11, 2024

What does this PR do?

Correct server and port in docs for serving TGI.
Note that port redirection is removed because we use --net=host.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?

@tengomucho
Copy link
Collaborator Author

@ManfeiBai I know you opened #38 before, but I think this might be a cleaner solution, please let me know if it is fine for you.

@tengomucho tengomucho marked this pull request as ready for review June 11, 2024 15:41
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@ManfeiBai
Copy link
Collaborator

@ManfeiBai I know you opened #38 before, but I think this might be a cleaner solution, please let me know if it is fine for you.

thanks, this looks more clean, and let's merge this PR, would close #38 after this PR merge

@tengomucho tengomucho merged commit c2da46d into main Jun 12, 2024
1 check passed
@tengomucho tengomucho deleted the fix-docs-serving-address-port branch June 12, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants