Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: attention mask should be 1 or 0" #8

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

tengomucho
Copy link
Collaborator

What does this PR do?

Fix attention mask update as it was intended to be.

This reverts commit dc15e65.

The fix was actually wrong, and it needs to be reverted.
@tengomucho tengomucho marked this pull request as ready for review March 26, 2024 09:52
@tengomucho tengomucho merged commit fecab96 into main Mar 26, 2024
1 check passed
@mfuntowicz mfuntowicz deleted the fix-attention-mask-update branch March 28, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant