New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the offline support for the ONNX/TFLite export #1109
Improve the offline support for the ONNX/TFLite export #1109
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
optimum/exporters/tasks.py
Outdated
revision = f.read() | ||
cached_path = Path(full_model_path, "snapshots", revision, subfolder) | ||
all_files = [ | ||
os.path.relpath(os.path.join(dirpath, file), cached_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We should stick to the pathlib API here instead of mixing pathlib and os.path IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
Fixes #1104