Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "to ONNX" from info message when exporting model #1627

Merged

Conversation

helena-intel
Copy link
Contributor

@helena-intel helena-intel commented Jan 8, 2024

This message is also shown when exporting models to OpenVINO format (in optimum-intel), which does not use ONNX. Replaced "Using pt to export to ONNX" with "Using pt to export the model".

@echarlaix

This message is also shown when exporting models to OpenVINO format, which does not use ONNX.
Replaced "Using pt to export to ONNX" with "Using pt to export the model".
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @helena-intel

@echarlaix echarlaix merged commit 0f0a663 into huggingface:main Jan 8, 2024
54 of 62 checks passed
vidalmaxime pushed a commit to vidalmaxime/optimum that referenced this pull request Jan 8, 2024
fxmarty pushed a commit that referenced this pull request Jan 26, 2024
* io binding for ortmodelforctc

* io binding for ortmodelforctc

* Remove "to ONNX" from info message when exporting model (#1627)

* ortmodelforctc iobinding test

* made sure use_io_binding is False due to line 318 in modeling_ort.py

---------

Co-authored-by: Ubuntu <tranceformer@tranceformer.m35het0djx5ejl3pyvcqpe3bfg.ax.internal.cloudapp.net>
Co-authored-by: Helena Kloosterman <helena.kloosterman@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants