Enable export of model with fixed shape #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mht-sharma
requested review from
fxmarty,
echarlaix and
michaelbenayoun
and removed request for
fxmarty and
echarlaix
fxmarty
reviewed
Jan 12, 2024
optimum/exporters/onnx/__main__.py
Outdated
Comment on lines
450
to
453
| if library_name == "timm" and no_dynamic_axes is False and "vovnet" in model_type: | ||
| raise ValueError( | ||
| f"The export of {model_type} is not supported with dynamic axes. Please pass --no-dynamic-axes to export the model with fixed shapes" | ||
| ) |
There was a problem hiding this comment.
I wonder rather avoid adding more model-specific code in here. Is it possible to move it elsewhere (like model_configs.py)?
There was a problem hiding this comment.
This could not be possible, as the variable (no_dynamic_axes) is not under the scope of model_configs.py.
For now I have removed this from here. In documentation, it is mentioned that the following architecture support is limited.
optimum/exporters/onnx/__main__.py
Outdated
| @@ -444,6 +447,11 @@ def main_export( | |||
| f" `--task {task_non_past} --monolith`, or `--task {task}` without the monolith argument." | |||
| ) | |||
|
|
|||
| if library_name == "timm" and no_dynamic_axes is False and "vovnet" in model_type: | |||
There was a problem hiding this comment.
Suggested change
| if library_name == "timm" and no_dynamic_axes is False and "vovnet" in model_type: | |
| if library_name == "timm" and not no_dynamic_axes and "vovnet" in model_type: |
There was a problem hiding this comment.
Added a small test, testing only a few models from transformers and vovnet from timm. This should be sufficient to see if it functionally works.
Should we extend testing to cover all supported models?
mht-sharma
force-pushed
the
no_dynamic_axes
branch
from
9d2e762
to
b1af6f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable export of the models with fixed shapes.
This is required to support export of model like "vovnet" which cannot be exported with dynamic shapes.
optimum-cli export onnx --model timm/ese_vovnet39b.ra_in1k out_vov --no-dynamic-axesBefore submitting